Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-63855 Tasks and issues related to flaky tests
  3. QTBUG-63992

cleanup tests [qtbase]: usages of QTest::qWait(int ms)

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • Testing: qtestlib
    • None

    Description

      This API (unconditional wait) enables people to write bad and flakey tests. Should this API be eventually deprecated? Maybe there are valid use cases for it? Need to look at the test first. Maybe some other primitives should be build on top of https://codereview.qt-project.org/#/c/205012/ instead?

      Counting with grep in qtbase at 40fe5d43fdc6a95332d19de3e716aab5040dee19 :

      qtbase/tests/auto$ grep -r "QTest::qWait(" * | wc -l
1118 <------- !!!!!

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            paeglis Gatis Paeglis
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: