Loading...

XML

Word

Printable

Type: Task
Resolution: Done
Priority: P2: Important
Fix Version/s: 5.13.0
Affects Version/s: None
Component/s: GUI: Basic Input System (keyboard, mouse, touch), QPA: Wayland, QPA: X11/XCB
Labels:
None

There are way too much duplicated code, e.g. ::keysymToQtKey():

QWaylandXkb::keysymToQtKey in qtwayland/src/shared/qwaylandxkb.cpp
QLibInputKeyboard::keysymToQtKey in qtbase/src/platformsupport/input/libinput/qlibinputkeyboard.cpp
And the originating source code QXcbKeyboard::keysymToQtKey in qtbase/src/plugins/platforms/xcb/qxcbkeyboard.cpp

And other code that uses libxkbcommon (e.g. for shortcut handling, compose key input) could benefit from sharing. All this should be cleaned up and shared.

relates to

QTBUG-62102 QKeySequenceEdit handles meta keys incorrectly on Wayland

Closed

QTBUG-62786 Missing QPlatformIntegration::queryKeyboardModifiers() implementation in Wayland QPA

Closed

QTBUG-66497 Ctrl+Letter shortcuts don't work on Wayland with non-US keyboard layout

Closed

QTBUG-71423 Unify cursor name lookup handling on linux

Reported

QTBUG-60005 When configuring with -qt-xkbcommon and -xkb-config-root, it will still try pkgconfig to detect xkbcommon

Closed

QTBUG-60224 Installed qtbase not compiled with xkbcommon-evdev support

Closed

QTBUG-71614 some of 2+ bytes unicode characters are broken

Closed

QTBUG-42181 Use libxkbcommon compose key API in QComposeInputContext plugin.

Closed

(3 relates to)

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-65503
#	Subject	Branch	Project	Status	CR	V
217267,15	xcb: refactor QXcbKeyboard::keysymToQtKey() and fix bug	5.11	qt/qtbase	Status: MERGED	+2	0
217342,14	xcb: use keysym defs from xkbcommon, instead of X11 headers	5.11	qt/qtbase	Status: MERGED	+2	0
218978,4	xcb: remove X11 deps from QXcbKeyboard::checkForLatinLayout/lookupLatinKeysym()	5.11	qt/qtbase	Status: MERGED	+2	0
245836,8	src/3rdparty: remove xkbcommon	5.12	qt/qtbase	Status: MERGED	-2	0
247324,14	platformsupport/input: add xkbcommon utilities lib	5.13	qt/qtbase	Status: MERGED	-2	0
247511,7	platformsupport/input: add static xkbcommon helper lib	5.12	qt/qtbase	Status: ABANDONED	-2	0
248181,19	client: rework input method handling	5.13	qt/qtwayland	Status: MERGED	-2	0
248386,24	drop qwaylandxkb and share the logic with X11	5.13	qt/qtwayland	Status: MERGED	-2	0