Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-65503

Unify key handling code on linux

    XMLWordPrintable

Details

    Description

      There are way too much duplicated code, e.g. ::keysymToQtKey():

      QWaylandXkb::keysymToQtKey in qtwayland/src/shared/qwaylandxkb.cpp
QLibInputKeyboard::keysymToQtKey in qtbase/src/platformsupport/input/libinput/qlibinputkeyboard.cpp
And the originating source code QXcbKeyboard::keysymToQtKey in qtbase/src/plugins/platforms/xcb/qxcbkeyboard.cpp

      And other code that uses libxkbcommon (e.g. for shortcut handling, compose key input) could benefit from sharing. All this should be cleaned up and shared.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-62102 QKeySequenceEdit handles meta keys incorrectly on Wayland

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-62786 Missing QPlatformIntegration::queryKeyboardModifiers() implementation in Wayland QPA

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-66497 Ctrl+Letter shortcuts don't work on Wayland with non-US keyboard layout

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-71423 Unify cursor name lookup handling on linux

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-60005 When configuring with -qt-xkbcommon and -xkb-config-root, it will still try pkgconfig to detect xkbcommon

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-60224 Installed qtbase not compiled with xkbcommon-evdev support

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-71614 some of 2+ bytes unicode characters are broken

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-42181 Use libxkbcommon compose key API in QComposeInputContext plugin.

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-65503
          # Subject Branch Project Status CR V
          217267,15 xcb: refactor QXcbKeyboard::keysymToQtKey() and fix bug 5.11 qt/qtbase Status: MERGED +2 0
          217342,14 xcb: use keysym defs from xkbcommon, instead of X11 headers 5.11 qt/qtbase Status: MERGED +2 0
          218978,4 xcb: remove X11 deps from QXcbKeyboard::checkForLatinLayout/lookupLatinKeysym() 5.11 qt/qtbase Status: MERGED +2 0
          245836,8 src/3rdparty: remove xkbcommon 5.12 qt/qtbase Status: MERGED -2 0
          247324,14 platformsupport/input: add xkbcommon utilities lib 5.13 qt/qtbase Status: MERGED -2 0
          247511,7 platformsupport/input: add static xkbcommon helper lib 5.12 qt/qtbase Status: ABANDONED -2 0
          248181,19 client: rework input method handling 5.13 qt/qtwayland Status: MERGED -2 0
          248386,24 drop qwaylandxkb and share the logic with X11 5.13 qt/qtwayland Status: MERGED -2 0

          Activity

            People

              paeglis Gatis Paeglis
              paeglis Gatis Paeglis
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: