Details
-
Bug
-
Resolution: Done
-
P2: Important
-
None
-
5.12
-
None
Description
Investigate re-implementing https://codereview.qt-project.org/#/c/241129/ into Qt 5.12
The patch was reverted in https://codereview.qt-project.org/#/c/245480 but doing so results in an approxamate 12% performance loss in the creation/quick.controls2/delegates_menu_custom.qml benchmark for QMLBench
Can it be determined if https://codereview.qt-project.org/#/c/241129/ is now safe to re-implement?
QMLBench results:
Commit d56c193eb4ceb640611d66f22e1f26aae91cd7d1 (QQuickPopupPositioner: avoid adding duplicate item change listeners) scored 389
Commit d3545dbdfdb30e310c6c962ba92f4fdf57354666 (Revert all Menu delegate patches) scored 345