Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74709

Improve performance of QQuickPopupPositioner

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P2: Important P2: Important
    • None
    • 5.12
    • Quick: Controls 2
    • None

      Investigate re-implementing https://codereview.qt-project.org/#/c/241129/ into Qt 5.12

       

      The patch was reverted in https://codereview.qt-project.org/#/c/245480 but doing so results in an approxamate 12% performance loss in the creation/quick.controls2/delegates_menu_custom.qml benchmark for QMLBench

       

      Can it be determined if https://codereview.qt-project.org/#/c/241129/ is now safe to re-implement?

       

      QMLBench results:

      Commit d56c193eb4ceb640611d66f22e1f26aae91cd7d1 (QQuickPopupPositioner: avoid adding duplicate item change listeners) scored 389

      Commit d3545dbdfdb30e310c6c962ba92f4fdf57354666 (Revert all Menu delegate patches) scored 345

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            mitch_curtis Mitch Curtis
            daniel.smith Daniel Smith
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes