Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74764

Downloading one file more than 100 times does not work properly on Windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Fixed
    • Affects Version/s: 5.12.2, 5.13.0 Beta 1
    • Fix Version/s: 5.12.3, 5.13.0 Beta2
    • Component/s: WebEngine
    • Labels:
      None
    • Platform/s:
      Windows
    • Commits:
      1110b9b50e61bf2663e2037ce9e28e74a8943919

      Description

      For the first 100 times the files is supposed to be suffixed by an index. For example, test (1).txt

      For the 101 time (and after) it is supposed to be suffixed with a timestamp. For example, test - 2019-03-28T08:45:29.355Z.txt

      See, https://codereview.qt-project.org/#/c/247517/

      Using colons (:) in filenames on Windows is not valid thus this results the 101st file to be downloaded to weird folders depending on the position and the numbers of the colons in the filename.

      Chrome just omits the colons from the filenames on Windows: test - 2019-03-28T093845.393.txt WebEngine should adapt this behavior.

      NOTE: this makes tst_QWebEngineDownloadItem::downloadUniqueFileNameWithTimeStamp auto test fail on Windows.

       

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              pvarga Peter Varga
              Reporter:
              pvarga Peter Varga
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes