Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
5.12.2, 5.13.0 Beta 1
-
None
-
-
1110b9b50e61bf2663e2037ce9e28e74a8943919
Description
For the first 100 times the files is supposed to be suffixed by an index. For example, test (1).txt
For the 101 time (and after) it is supposed to be suffixed with a timestamp. For example, test - 2019-03-28T08:45:29.355Z.txt
See, https://codereview.qt-project.org/#/c/247517/
Using colons (:) in filenames on Windows is not valid thus this results the 101st file to be downloaded to weird folders depending on the position and the numbers of the colons in the filename.
Chrome just omits the colons from the filenames on Windows: test - 2019-03-28T093845.393.txt WebEngine should adapt this behavior.
NOTE: this makes tst_QWebEngineDownloadItem::downloadUniqueFileNameWithTimeStamp auto test fail on Windows.
Attachments
Issue Links
- relates to
-
QTBUG-74698 QtWebEngine windows 10 msvc 2017 tests fails with tst_QWebEngineDownloadItem::downloadUniqueFilename
-
- Closed
-
- resulted from
-
QTBUG-66262 Wrong positon of suggested file name counter in QWebEngineDownloadItem.
-
- Closed
-
For Gerrit Dashboard: QTBUG-74764 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
257348,2 | Skip downloadUniqueFileNameWithTimeStamp auto test on Windows | 5.13 | qt/qtwebengine | Status: MERGED | +2 | 0 |
257397,2 | Fix timestamp deduplication for Windows | 5.12 | qt/qtwebengine | Status: MERGED | +2 | 0 |
257398,3 | Unskip downloadUniqueFilenameWithTimestamp auto test | 5.13 | qt/qtwebengine | Status: MERGED | +2 | 0 |