Details
-
Technical task
-
Resolution: Done
-
P1: Critical
-
None
-
iOS/tvOS/watchOS,
-
37c770825c1174c274fd09b2da1a7438d8c0a363 (qt/qtconnectivity/dev)
Description
A few iOS/macOS implementations have their own public class implementations (e.g. QLowEnergyService)
- Removes duplicated code
- Likely due to Objective C specifics -> needs investigation. Mainly due to osx-specific private header files containing Objective C entities, which will fail to compile when included in *.cpp file. Working this around is possible, albeit a bit ugly but is still better than code duplication.
Attachments
| For Gerrit Dashboard: QTBUG-75348 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 259500,6 | WIP: deduplicate public API implementation | dev | qt/qtconnectivity | Status: DEFERRED | -2 | 0 |
| 259830,9 | IO/CoreBluetooth - refactor the code a bit | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
| 259846,23 | De-duplicate device discovery code (Darwin) | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
| 260701,36 | LE controller/service remove code duplication (Darwin) | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
| 261144,1 | WIP: QBluetoothServiceInfo - remove Darwin-specific duplicate | dev | qt/qtconnectivity | Status: ABANDONED | -2 | 0 |
| 267119,9 | QBluetoothServer - cleanup and de-duplicate code | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
| 267138,5 | QBluetoothSocket - deduplicate the code (macOS) | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
| 267228,3 | QBluetoothServiceInfo - remove the code-duplicate (macOS) | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
| 267461,4 | Service discovery agent - remove the public API implementation (macOS) | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
