Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
0a1e4cc7ec7548f6273befff9cdddb0bc7a58961 (qt/qtdeclarative/dev), 4077b0594 (dev), dcbb2f19b (6.7)
Description
Currently, we intercept url properties as soon as the property is set, but only if it is a simple QUrl. If it is a JavaScript expression, it does not get intercepted.
In QML 3, we probably only want to intercept urls at the place where they are actually used. This would mean that any redirection is applied after any interception, and only the original URL is stored and used for further URL resolution. This is different to what e.g. HTML does.
QTBUG-61209 and https://codereview.qt-project.org/214106 show that we have a more complicated problem there: Redirected URLs cannot be intercepted and vice versa. Right now, we circumvent the problem by using the original, non-redirected, URL for resolving further URLs in case of a redirection. This is different from how e.g. HTML handles URLs, and rather unintuitive.
There is a solution: We could restrict interception to local URLs and redirection to remote ones. Furthermore we could prohibit local URLs to be made remote by interception.
URL interception right now is only possible by using private API and our own interception only concerns QQmlFileSelector, which only handles local URLs anyway. However, the relevant headers, qqmlabstracturlinterceptor.h and qqmlengine.h, are in fact public. Only the setUrlInterceptor() and urlInterceptor() methods are marked internal by qdoc comments. Therefore you won't get the familiar private API warning when using them.
Such a change would reduce the (rather ugly) code in that area, and result in cleaner rules on what works and what doesn't. On the flip side there are probably users of this API who don't realize that it's private and whose code will break this way.
Attachments
Issue Links
- is duplicated by
-
QTBUG-66690 Fix discrepancy between redirection and interception of URLs when loading QML
- Closed
- relates to
-
PYSIDE-1704 qt.qml.import: addImportPath: "/usr/bin"
- Closed
-
QTBUG-81244 QML url type automatically performs some URL decoding
- Closed
- resulted in
-
QTBUG-100469 Qml runtime resizeToItem configuration is not working
- Closed
-
QTBUG-88965 QML property with 'url' type resolves incorrectly
- Closed
For Gerrit Dashboard: QTBUG-76879 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
267002,4 | Intercept image source url | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
304441,5 | Do not resolve URLs when assigning them to a property | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
524532,3 | Resolve source URL just-in-time in QQuickTextDocument | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
524961,2 | Resolve source URL just-in-time in QQuickTextDocument | 6.7 | qt/qtdeclarative | Status: MERGED | +2 | 0 |