Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74406 Abstract away the graphics APIs in Qt
  3. QTBUG-78573

Port neglected fixes and improvements from the OpenGL-specific ShaderEffect impl. to the generic

    XMLWordPrintable

    Details

    • Type: Technical task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Fix Version/s: 6.0
    • Component/s: Qt RHI, Quick: SceneGraph
    • Labels:
      None

      Description

      Unfortunately fixes were made to QQuickOpenGLShaderEffect(Node) during the past 2 years, without porting these to QQuickGenericShaderEffect, which is now also used by the RHI code path. Before 5.14 the "generic" implementation was only in use when one chose to run with the rarely used d3d12 backend of Qt Quick. With the QRhi-based story the generic implementation is the primary (and only) way to back ShaderEffect.

      The implentations should be synchronized before removing the OpenGL version. For exampe, port the signalmapper related changes and whatever else got changed. Then verify it all still works.

      Once this is done we can remove the OpenGL-specific shadereffect node implementation. This is harder than it looks, and there is also some functionality (UniformAnimator?) that has never been ported to the generic (adaptation layer based) shader effect node...

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              tvete Paul Olav Tvete
              Reporter:
              lagocs Laszlo Agocs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes