Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74406 Abstract away the graphics APIs in Qt
  3. QTBUG-78573

Port neglected fixes and improvements from the OpenGL-specific ShaderEffect impl. to the generic

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Done
    • P2: Important
    • 6.0
    • Qt RHI, Quick: SceneGraph
    • None

    Description

      Unfortunately fixes were made to QQuickOpenGLShaderEffect(Node) during the past 2 years, without porting these to QQuickGenericShaderEffect, which is now also used by the RHI code path. Before 5.14 the "generic" implementation was only in use when one chose to run with the rarely used d3d12 backend of Qt Quick. With the QRhi-based story the generic implementation is the primary (and only) way to back ShaderEffect.

      The implentations should be synchronized before removing the OpenGL version. For exampe, port the signalmapper related changes and whatever else got changed. Then verify it all still works.

      Once this is done we can remove the OpenGL-specific shadereffect node implementation. This is harder than it looks, and there is also some functionality (UniformAnimator?) that has never been ported to the generic (adaptation layer based) shader effect node...

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-84299 RHI shader effect copies atlas texture when qt_SubRect_ uniform is used

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Technical task - A technical task. QTBUG-78612 Verify and fix texture subrect in ShaderEffect when running with QRhi in Qt Quick

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-83975 Make sure there are lancelot test cases for all Quick ShaderEffect features

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-83976 Port UniformAnimator to the generic ShaderEffect implementation

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-84123 Port qquickshadereffect autotest to RHI

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-84377 Port shader effect property connection optimization to QQuickGenericShaderEffect

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          is required for

          Technical task - A technical task. QTBUG-79268 Purge direct OpenGL code path in Qt Quick

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Task - A task that needs to be done. QTBUG-83977 Remove QQuickOpenGLShaderEffect*

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              tvete Paul Olav Tvete
              lagocs Laszlo Agocs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes