Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-84299

RHI shader effect copies atlas texture when qt_SubRect_ uniform is used

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 6.0
    • Fix Version/s: None
    • Component/s: Qt RHI, Quick: SceneGraph
    • Labels:
      None
    • Commits:
      84e87fd38e7cff31b88abc52d774299890545b92 (qt/qtdeclarative/dev)

      Description

      There are two ways of preventing copying with atlased textures:

      The first is to set supportsAtlasTextures to true, which is supported by the RHI implementation.

      The second is to add a qt_SubRect_foo uniform to the vertex shader. This does not work with RHI, because QSGRhiShaderEffectMaterialShader::updateSampledImage() only checks m_geometryUsesTextureSubRect, which is only set if supportsAtlasTextures is true.

        Attachments

          Issue Links

          is required for

          Technical task - A technical task. QTBUG-78573 Port neglected fixes and improvements from the OpenGL-specific ShaderEffect impl. to the generic

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Technical task - A technical task. QTBUG-78612 Verify and fix texture subrect in ShaderEffect when running with QRhi in Qt Quick

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              tvete Paul Olav Tvete
              Reporter:
              tvete Paul Olav Tvete
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes