Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-84299

RHI shader effect copies atlas texture when qt_SubRect_ uniform is used

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 6.0
    • Qt RHI, Quick: SceneGraph
    • None
    • 84e87fd38e7cff31b88abc52d774299890545b92 (qt/qtdeclarative/dev)

    Description

      There are two ways of preventing copying with atlased textures:

      The first is to set supportsAtlasTextures to true, which is supported by the RHI implementation.

      The second is to add a qt_SubRect_foo uniform to the vertex shader. This does not work with RHI, because QSGRhiShaderEffectMaterialShader::updateSampledImage() only checks m_geometryUsesTextureSubRect, which is only set if supportsAtlasTextures is true.

      Attachments

        Issue Links

          is required for

          Technical task - A technical task. QTBUG-78573 Port neglected fixes and improvements from the OpenGL-specific ShaderEffect impl. to the generic

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Technical task - A technical task. QTBUG-78612 Verify and fix texture subrect in ShaderEffect when running with QRhi in Qt Quick

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-84299
          # Subject Branch Project Status CR V
          301401,3 Don't detach from atlas when using qt_SubRect_foo dev qt/qtdeclarative Status: MERGED +2 0

          Activity

            People

              tvete Paul Olav Tvete
              tvete Paul Olav Tvete
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes