Priority: P2: Important
Affects Version/s: 5.14.1, 5.15.0, 6.0.0
Fix Version/s: None
Component/s: Build tools: moc
I like to use "-Wextra-semi-stmt" in my application code. But the moc adds some Q_UNUSED with and without a semicolon. It would be helpful to unify this.
I tried to change this but it seems that Qt6 should switch the ; behaviour in user code.
Patch Set 1:
The consensus I've seen is that uses should have the semicolon, and Q_UNUSED should lose its semicolon (Qt6?)
Thiago Macieira Code-Review +1
Patch Set 1: Code-Review+1
I'd rather we changed the macro not to add it, but that's source incompatible.
change the macro would also be nice to let the user add the ; as it is confusing for a developer and the code formatter.
|For Gerrit Dashboard: QTBUG-82978|
|305982,1||Add ; to Q_UNUSED||dev||qt/qtpim||Status: NEW||+2||0|
|305984,1||Add ; to Q_UNUSED||dev||qt/qtserialbus||Status: NEW||-2||0|
|305986,1||Add ; to Q_UNUSED||dev||qt/qtsystems||Status: NEW||0||0|
|307220,2||Remove ; from the Q_UNUSED macro||dev||qt/qtbase||Status: NEW||0||0|