Details
-
Bug
-
Resolution: Done
-
P2: Important
-
None
-
5.14.1, 5.15.0, 6.0.0
-
None
-
71223cc92ba1039f0dfde1bb30d3cccdab30c4dd (qt/qtbase/dev) 2efc1cd6aa2f9a4797ba22fcde8acf1fa7e777d1 (qt/qtbase/5.15)
Description
I like to use "-Wextra-semi-stmt" in my application code. But the moc adds some Q_UNUSED with and without a semicolon. It would be helpful to unify this.
I tried to change this but it seems that Qt6 should switch the ; behaviour in user code.
https://codereview.qt-project.org/c/qt/qtbase/+/258285
Mårten Nordheim
Patch Set 1:
The consensus I've seen is that uses should have the semicolon, and Q_UNUSED should lose its semicolon (Qt6?)
Thiago Macieira Code-Review +1
Patch Set 1: Code-Review+1
I'd rather we changed the macro not to add it, but that's source incompatible.
change the macro would also be nice to let the user add the ; as it is confusing for a developer and the code formatter.
Attachments
Issue Links
- is required for
-
QTBUG-62425 Changes planned for Qt 6
-
- Closed
-
For Gerrit Dashboard: QTBUG-82978 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
303852,3 | Add ; to Q_UNUSED | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
304838,3 | Add ; to Q_UNUSED | dev | qt/qtsvg | Status: MERGED | +2 | 0 |
304839,3 | Add ; to Q_UNUSED | dev | qt/qtwebsockets | Status: MERGED | +2 | 0 |
305394,4 | Add ; to Q_UNUSED | dev | qt/qt3d | Status: MERGED | +2 | 0 |
305411,2 | Add ; to Q_UNUSED | dev | qt/qtactiveqt | Status: MERGED | +2 | 0 |
305413,2 | Add ; to Q_UNUSED | dev | qt/qtandroidextras | Status: MERGED | +2 | 0 |
305875,2 | Add ; to Q_UNUSED | dev | qt/qtcharts | Status: MERGED | +2 | 0 |
305876,1 | Add ; to Q_UNUSED | dev | qt/qtcanvas3d | Status: ABANDONED | 0 | 0 |
305877,2 | Add ; to Q_UNUSED | dev | qt/qtdatavis3d | Status: MERGED | +2 | 0 |
305878,3 | Add ; to Q_UNUSED and UNUSED_PARAM | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
305962,2 | Add ; to Q_UNUSED | dev | qt/qtconnectivity | Status: MERGED | +2 | 0 |
305963,3 | Add ; to Q_UNUSED | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
305964,2 | Add ; to Q_UNUSED | dev | qt/qtgamepad | Status: MERGED | +2 | 0 |
305965,2 | Add ; to Q_UNUSED | dev | qt/qtlocation | Status: MERGED | +2 | 0 |
305966,2 | Add ; to Q_UNUSED | dev | qt/qtmultimedia | Status: MERGED | +2 | 0 |
305967,2 | Add ; to Q_UNUSED | dev | qt/qtnetworkauth | Status: MERGED | +2 | 0 |
305968,2 | Add ; to Q_UNUSED | dev | qt/qtpurchasing | Status: MERGED | +2 | 0 |
305969,2 | Add ; to Q_UNUSED | dev | qt/qtqa | Status: MERGED | +2 | 0 |
305970,2 | Add ; to Q_UNUSED | dev | qt/qtquick3d | Status: MERGED | +2 | 0 |
305971,2 | Add ; to Q_UNUSED | dev | qt/qtquickcontrols | Status: MERGED | +2 | 0 |
305972,2 | Add ; to Q_UNUSED | dev | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
305973,2 | Add ; to Q_UNUSED | dev | qt/qtscxml | Status: MERGED | +2 | 0 |
305974,2 | Add ; to Q_UNUSED | dev | qt/qtsensors | Status: MERGED | +2 | 0 |
305975,2 | Add ; to Q_UNUSED | dev | qt/qtserialport | Status: MERGED | +2 | 0 |
305976,2 | Add ; to Q_UNUSED | dev | qt/qttools | Status: MERGED | +2 | 0 |
305977,2 | Add ; to Q_UNUSED | dev | qt/qtvirtualkeyboard | Status: MERGED | +2 | 0 |
305978,2 | Add ; to Q_UNUSED | dev | qt/qtwayland | Status: MERGED | +2 | 0 |
305979,2 | Add ; to Q_UNUSED | dev | qt/qtwebengine | Status: MERGED | +2 | 0 |
305980,2 | Add ; to Q_UNUSED | dev | qt/qtwebview | Status: MERGED | +2 | 0 |
305981,1 | Add ; to Q_UNUSED | dev | qt/qtxmlpatterns | Status: ABANDONED | 0 | 0 |
305982,12 | Add ; to Q_UNUSED | dev | qt/qtpim | Status: MERGED | +2 | 0 |
305983,4 | Add ; to Q_UNUSED | dev | qt/qtremoteobjects | Status: MERGED | +2 | 0 |
305984,2 | Add ; to Q_UNUSED | dev | qt/qtserialbus | Status: MERGED | +2 | 0 |
305985,2 | Add ; to Q_UNUSED | dev | qt/qtspeech | Status: MERGED | +2 | 0 |
305986,1 | Add ; to Q_UNUSED | dev | qt/qtsystems | Status: ABANDONED | 0 | 0 |
305987,11 | Add ; to Q_UNUSED | dev | qt/qtbase | Status: MERGED | +2 | 0 |
306135,8 | Refactor tst_Collections | dev | qt/qtbase | Status: MERGED | +2 | 0 |
306624,3 | Avoid use of Q_UNUSED by eliminating the parameter names | dev | qt/qtbase | Status: MERGED | +2 | 0 |
306625,6 | Remove unnecessary ; after function implementations | dev | qt/qtbase | Status: MERGED | +2 | 0 |
306635,3 | Only use one macro per line | dev | qt/qtbase | Status: MERGED | +2 | 0 |
306637,3 | Use Q_DECL_UNUSED_MEMBER instead of Q_UNUSED | dev | qt/qtbase | Status: MERGED | +2 | 0 |
306640,4 | Cleanup qtestspontaneevent.h for Qt 6 | dev | qt/qtbase | Status: MERGED | +2 | 0 |
318600,2 | Allow to use Q_UNUSED without a semicolon in macro | dev | qt/qtbase | Status: ABANDONED | -2 | 0 |
318853,3 | Use (void) instead of Q_UNUSED | dev | qt/qtbase | Status: MERGED | +2 | 0 |
319759,3 | Use (void) instead of Q_UNUSED | 5.15 | qt/qtbase | Status: MERGED | +2 | 0 |