Details
-
Suggestion
-
Resolution: Done
-
Not Evaluated
-
None
-
None
-
Q1/2020 Finale, Q2/2020 kick off, Bug Fixing Candidates
Description
https://doc.qt.io/qt-5/qquickitem.html
The convention in Qt Quick and Qt Quick Controls 2 is to use "nounChange" for virtual functions that should handle some change, and "nounChanged" for signals that notify objects of that change.
geometryChanged does not follow that convention:
virtual void geometryChanged(const QRectF &newGeometry, const QRectF &oldGeometry)
compare that to itemChange:
virtual void itemChange(QQuickItem::ItemChange change, const QQuickItem::ItemChangeData &value)
Not only would renaming geometryChanged to geometryChange allow us to fix this inconsistency, but it would also allow us to add a geometryChanged signal as a public API (item change listeners are private) for listening to geometry changes in an item without listening to all individual x/y/width/height properties: QTBUG-83050
Attachments
Issue Links
- is required for
-
QTBUG-73063 Qt Quick Changes in Qt 6
-
- Open
-
-
QTBUG-83050 Add a geometryChanged signal to QQuickItem
-
- Reported
-
For Gerrit Dashboard: QTBUG-82994 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
294827,5 | QQuickItem: rename geometryChanged to geometryChange | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
294830,3 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtlocation | Status: ABANDONED | +2 | 0 |
294915,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtquickcontrols2 | Status: MERGED | +2 | 0 |
294921,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtwebengine | Status: MERGED | +2 | 0 |
294923,1 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtcharts | Status: ABANDONED | +2 | 0 |
294924,1 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtcanvas3d | Status: ABANDONED | +2 | 0 |
294925,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtwebview | Status: MERGED | +2 | 0 |
294926,1 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtdatavis3d | Status: ABANDONED | +2 | 0 |
294927,1 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtgamepad | Status: ABANDONED | +2 | 0 |
294928,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtquick3d | Status: MERGED | +2 | 0 |
294930,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtmultimedia | Status: MERGED | +2 | 0 |
307839,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt-extensions/qtquickcalendar | Status: MERGED | +2 | 0 |
308896,2 | Adapt to geometryChanged => geometryChange renaming | dev | qt/qtcharts | Status: MERGED | +2 | 0 |