Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-85581

QByteArray .toDouble() does not call nulTerminated()

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • P3: Somewhat important
    • None
    • 5.15.0
    • Core: Containers and Algorithms
    • None
    • All
    • 8

    Description

      All of the QByteArray .toInt() .toLong(), etc methods call the internal function nulTerminated() which ensures that the buffer being processed is terminated with a NUL character.

      .toDouble() doesn't do this – which would not be a problem except for the fact that the numLen argument being passed to qt_asciiToDouble is not being respected inside that function (it may read past the end of buffer).  See related issue: QTBUG-85580.

      As such, I suggest either fixing QTBUG-85580 above or if not, then making .toDouble() operate on an enforced nulTerminated() buffer.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. QTBUG-74286 Reimplement QLocaleData::stringTo(Uns|)LongLong() to take size of string

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Suggestion - Public suggestions QTBUG-66115 Let (QString|QLocale)::toFloat ignore trailing non-digits

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-85580 Often-used function `qt_asciiToDouble` may read past end of buffer

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              thiago Thiago Macieira
              cculianu calin culianu
              Maurice Kalinowski Maurice Kalinowski
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes