Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-89410

Change default CMAKE_BUILD_TYPE to Release

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build System: CMake
    • Labels:

      Description

      Currently QtSetup.cmake checks if there's a ".git" dir and defaults to CMAKE_BUILD_TYPE=Debug in such a case.

      That's kinda weird considering it somewhat overlaps with FEATURE_developer_build.

      We should probably remove the .git check, and just default to Release.

      Explicitly opting into FEATURE_developer_build should set it to Debug.

      This may or may not have some consequences in the CI, per-repo builds, and standalone tests builds.

      So care should be taken to check all those cases.

        Attachments

          Issue Links

          For Gerrit Dashboard: QTBUG-89410
          # Subject Branch Project Status CR V

            Activity

              People

              Assignee:
              semlanik Alexey Edelev
              Reporter:
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes