Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
-
5d6f2238548fe8415e84099fc14470e189c9e726
Description
Currently QtSetup.cmake checks if there's a ".git" dir and defaults to CMAKE_BUILD_TYPE=Debug in such a case.
That's kinda weird considering it somewhat overlaps with FEATURE_developer_build.
We should probably remove the .git check, and just default to Release.
Explicitly opting into FEATURE_developer_build should set it to Debug.
This may or may not have some consequences in the CI, per-repo builds, and standalone tests builds.
So care should be taken to check all those cases.
Attachments
Issue Links
- is required for
-
QTBUG-89476 [REG 5.15 -> 6.0] Configure doesn't build for release by default
-
- Closed
-
| For Gerrit Dashboard: QTBUG-89410 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 327610,4 | CMake: Use Release build type by default | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 327682,2 | CMake: Use Release build type by default | 6.0 | qt/qtbase | Status: MERGED | +2 | 0 |