Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-96121

Versionless CMake commands prevent setting variables in calling scope

    XMLWordPrintable

Details

    Description

      Versionless CMake wrapper commands are often defined around the versioned equivalents. Some of those versioned commands take a variable name and will set a variable in the calling scope using that name, but the versionless wrapper commands have been implemented as functions instead of macros in many cases. They need to be macros to allow these variables to be set in the calling scope.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-96096 translations are not installed anymore

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-96219 Conversion of versionless wrapper functions to macros needs to be reverted

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-96121
          # Subject Branch Project Status CR V
          367698,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtshadertools Status: MERGED +2 0
          367699,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtquick3d Status: MERGED +2 0
          367700,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtremoteobjects Status: MERGED +2 0
          367703,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtbase Status: MERGED +2 0
          367757,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtbase Status: MERGED +2 0
          367760,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtshadertools Status: MERGED +2 0
          367763,3 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtquick3d Status: MERGED +2 0
          367769,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtremoteobjects Status: MERGED +2 0
          367784,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qttools Status: MERGED +2 0
          367958,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtactiveqt Status: MERGED +2 0
          367959,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtscxml Status: MERGED +2 0
          367961,3 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qttools Status: MERGED +2 0
          367962,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtwayland Status: MERGED +2 0
          368061,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtscxml Status: MERGED +2 0
          368069,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtwayland Status: MERGED +2 0
          368071,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtactiveqt Status: MERGED +2 0
          368072,2 Ensure versionless wrappers do not introduce a new variable scope dev qt/qtdeclarative Status: MERGED +2 0
          368233,2 Ensure versionless wrappers do not introduce a new variable scope 6.2 qt/qtdeclarative Status: MERGED +2 0
          369029,2 Fix cases of output variables not being passed back to calling scope dev qt/qtbase Status: MERGED +2 0
          369190,2 Fix cases of output variables not being passed back to calling scope 6.2 qt/qtbase Status: MERGED +2 0

          Activity

            People

              crscott Craig Scott
              crscott Craig Scott
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes