[QTBUG-96219] Conversion of versionless wrapper functions to macros needs to be reverted - Qt Bug Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: P2: Important
Resolution: Done
Affects Version/s: 6.2.0 Beta3
Fix Version/s: 6.2.0 RC
Component/s: Build System: CMake
Labels:
None

Description

Changes to address ~~QTBUG-96121~~ did not consider that macros introduce another level of escaping that functions do not. Converting the versionless wrapper functions to macros therefore introduced a potential behavior change. Those changes need to be reverted and an alternate fix applied for addressing the silent swallowing of output arguments by the wrappers.

See upstream CMake issue: https://gitlab.kitware.com/cmake/cmake/-/issues/19972

Attachments

Issue Links

resulted from

QTBUG-96121 Versionless CMake commands prevent setting variables in calling scope

Closed

Options
- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

Gerrit Reviews

For Gerrit Dashboard: QTBUG-96219
#	Subject	Branch	Project	Status	CR	V
369025,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtshadertools	Status: MERGED	+2	0
369026,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtquick3d	Status: MERGED	+2	0
369027,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtremoteobjects	Status: MERGED	+2	0
369028,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtbase	Status: MERGED	+2	0
369029,2	Fix cases of output variables not being passed back to calling scope	dev	qt/qtbase	Status: MERGED	+2	0
369030,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtactiveqt	Status: MERGED	+2	0
369031,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtscxml	Status: MERGED	+2	0
369032,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qttools	Status: MERGED	+2	0
369035,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtwayland	Status: MERGED	+2	0
369036,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	dev	qt/qtdeclarative	Status: MERGED	+2	0
369037,2	Fix OUTPUT_TARGETS not being set in parent scope in all cases	dev	qt/qtdeclarative	Status: MERGED	+2	0
369093,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtactiveqt	Status: MERGED	+2	0
369094,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtdeclarative	Status: MERGED	+2	0
369095,2	Fix OUTPUT_TARGETS not being set in parent scope in all cases	6.2	qt/qtdeclarative	Status: MERGED	+2	0
369097,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtshadertools	Status: MERGED	+2	0
369098,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtremoteobjects	Status: MERGED	+2	0
369099,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtwayland	Status: MERGED	+2	0
369100,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtscxml	Status: MERGED	+2	0
369101,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qttools	Status: MERGED	+2	0
369103,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtquick3d	Status: MERGED	+2	0
369189,2	Revert "Ensure versionless wrappers do not introduce a new variable scope"	6.2	qt/qtbase	Status: MERGED	+2	0
369190,2	Fix cases of output variables not being passed back to calling scope	6.2	qt/qtbase	Status: MERGED	+2	0