Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-96549

make clean removes ts file when using qt5_create_translation()

    XMLWordPrintable

Details

    • All
    • 153db2fedc (qt/qttools/dev) 44326eb79e (qt/qttools/6.3) fcb679fda3 (qt/qttools/6.2) fcb679fda3 (qt/tqtc-qttools/6.2) 44326eb79e (qt/tqtc-qttools/6.3) 153db2fedc (qt/tqtc-qttools/dev) a100f74851 (qt/tqtc-qttools/5.15) fcb679fda3 (qt/qttools/6.2.4)

    Description

      Bug report results from a forum post: https://forum.qt.io/topic/130308/manage-translations-with-cmake

      When using qt5_create_translation(), calling make clean (or e.g. execution 'Rebuild all' in QtCreator) will remove the ts files in the source directory.

      The reason for this is that the custom command to execute lupdate specifies the ts file as OUTPUT (which is correct) and therefore cmake sets the 'GENERATED' property which means the file gets deleted on make clean. Sadly this property can not be unset and I did not find a workaround.

      Attachments

        1. qtbug-96549.tgz
          1 kB
          Christian Ehrlicher

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-31860 CMake + Qt5LinguistToolsMacros.cmake: QT5_CREATE_TRANSLATION delete source ts files during clean

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-41736 CMake + Qt5LinguistToolsMacros.cmake: QT5_CREATE_TRANSLATION clean deletes .ts files instead of updating

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          relates to

          Task - A task that needs to be done. QTBUG-76410 CMake: Introduce qt_update_translation function

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-107853 qt6_add_translations() deletes CMake-generated *.ts files when project is cleaned

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-113152 [REG 5.15.8 -> 5.15.9] qt5_create_translation breaks projects with multiple same-named ts files

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          mentioned in

          Page Loading...

          For Gerrit Dashboard: QTBUG-96549
          # Subject Branch Project Status CR V
          396194,3 CMake: Fix qt_create_translation to not remove .ts files on "clean" dev qt/qttools Status: MERGED +2 0
          396304,2 CMake: Fix qt_create_translation to not remove .ts files on "clean" 6.3 qt/qttools Status: MERGED +2 0
          396305,2 CMake: Fix qt_create_translation to not remove .ts files on "clean" 6.2 qt/qttools Status: MERGED +2 0
          396330,3 CMake: Fix qt_create_translation to not remove .ts files on "clean" tqtc/lts-5.15 qt/tqtc-qttools Status: MERGED +2 0

          Activity

            People

              jbornema Joerg Bornemann
              chehrlic Christian Ehrlicher
              Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews