Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
Qt Creator 4.11.0-rc1
-
-
b9739c0945a1d7a1376f63c919ea9ec0f7f85ef8
Description
Right-clicking a commit hash in Git Blame editor shows the full hash, but also a short description of the change and of its parent (author and subject).
This is done in GitEditorWidget::decorateVersion(), which calls GitClient::synchronousShortDescription. This function executes git log with the following arguments (see defaultShortLogFormatC):
("log", "--no-color", "--pretty=format:%h (%an \"%s", "--max-count=1", "986210c2ef9")
This is translated in CommandLine to:
log --no-color "--pretty=format:%h (%an "\^""%s" "--max-count=1" 986210c2ef9
Now QtcProcess's doSplitArgsWin fails to split these arguments, as it claims they have bad quoting.
I tried to fix it, but I don't have much time right now, and I'm afraid I might break something, so please handle it.
Attachments
For Gerrit Dashboard: QTCREATORBUG-23208 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
280945,1 | WIP: QtcProcess: Add a test for split(add("a \"b")) | 4.11 | qt-creator/qt-creator | Status: ABANDONED | -2 | 0 |
290683,2 | Git: Hack around quoting problem with Short description on blame | 4.12 | qt-creator/qt-creator | Status: MERGED | +2 | 0 |