Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-23208

Regression[4.10->4.11]: Short description on Git Blame is broken

    XMLWordPrintable

Details

    • Windows
    • b9739c0945a1d7a1376f63c919ea9ec0f7f85ef8

    Description

      Right-clicking a commit hash in Git Blame editor shows the full hash, but also a short description of the change and of its parent (author and subject).

      This is done in GitEditorWidget::decorateVersion(), which calls GitClient::synchronousShortDescription. This function executes git log with the following arguments (see defaultShortLogFormatC):

      ("log", "--no-color", "--pretty=format:%h (%an \"%s", "--max-count=1", "986210c2ef9")

      This is translated in CommandLine to:

      log --no-color "--pretty=format:%h (%an "\^""%s" "--max-count=1" 986210c2ef9

      Now QtcProcess's doSplitArgsWin fails to split these arguments, as it claims they have bad quoting.

      I tried to fix it, but I don't have much time right now, and I'm afraid I might break something, so please handle it.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            hjk hjk
            orgads Orgad Shaneh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes