Details
-
Suggestion
-
Resolution: Fixed
-
P3: Somewhat important
-
None
-
Qt Creator 12.0.0
-
-
18205d623 (master)
Description
Sometimes committing to the VCS is not possible, e.g. when the commit message is empty or no files are checked or if the email address is invalid.
While the error message is already available internally in
bool SubmitEditorWidget::canSubmit(QString *whyNot) const;
it is not propagated to the UI. The submit button is disabled but the reason is not clear.
I suggest to add a tooltip or an error label near the submit button to inform the user.
Logging may also be appropriate.
Report originated from https://forum.qt.io/topic/154165/qtcreator-und-git
Attachments
Issue Links
- is required for
-
QTCREATORBUG-19721 Git user interface improvements
- Reported
- relates to
-
QTCREATORBUG-30748 Ctrl+Enter doesn't work in git commit window
- Closed
For Gerrit Dashboard: QTCREATORBUG-30333 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
589152,3 | VCS: Add error message when submit is not possible | master | qt-creator/qt-creator | Status: MERGED | +2 | +1 |