Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-30333

Show error reason when commiting is not possible

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • Icon: P3: Somewhat important P3: Somewhat important
    • None
    • Qt Creator 12.0.0
    • All
    • 18205d623 (master)

      Sometimes committing to the VCS is not possible, e.g. when the commit message is empty or no files are checked or if the email address is invalid.

      While the error message is already available internally in

      bool SubmitEditorWidget::canSubmit(QString *whyNot) const;

      it is not propagated to the UI. The submit button is disabled but the reason is not clear.

      I suggest to add a tooltip or an error label near the submit button to inform the user.

      Logging may also be appropriate.

      Report originated from https://forum.qt.io/topic/154165/qtcreator-und-git

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            aha_1980 André Hartmann
            aha_1980 André Hartmann
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes