Details
Description
When CreateLocalRepositoryOperation is running a lot of warnings about wrong progress calculation will be shown in the log.
Analysis:
In CreateLocalRepositoryOperation::performOperation() during extract of binary data the progress is emitted using
[code]
emit progressChanged(.65f + ((double / double(name.count())) * .25f));
[code]
The progress value generated here is wrong. I think "name.count()" should be "names.count()" to match the iterator variable used in the for loop. I'm not entirely sure, though.
Attachments
For Gerrit Dashboard: QTIFW-602 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
101855,2 | fix progress calculation | master | installer-framework/installer-framework | Status: ABANDONED | -1 | 0 |
101856,2 | fix progress calculation | 2.0 | installer-framework/installer-framework | Status: MERGED | +2 | 0 |