Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-602

CreateLocalRepositoryOperation progress calculation broken

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 2.0.0
    • 2.0.0
    • General
    • None
    • If96a1233c9eef6600e995b29e30e7d8dcf5c477d

    Description

      When CreateLocalRepositoryOperation is running a lot of warnings about wrong progress calculation will be shown in the log.

      Analysis:
      In CreateLocalRepositoryOperation::performOperation() during extract of binary data the progress is emitted using
      [code]
      emit progressChanged(.65f + ((double / double(name.count())) * .25f));
      [code]
      The progress value generated here is wrong. I think "name.count()" should be "names.count()" to match the iterator variable used in the for loop. I'm not entirely sure, though.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            installerteam Installer Team
            gordin Christoph Vogtländer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes