Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3935

Implement license checking for qt5.git repos (like qtbase) with new YAML instructions

XMLWordPrintable

    • 2a0e89981 (dev), 37dc5b91f (6.8), 0055441fc (dev), 11dcad85e (6.8), 6c6a63cc8 (dev), 5a67e61a0 (6.8), 701f688d9 (dev), 20b9d76ad (6.8)

      Currently all license checking is implemented via a legacy Coin feature called LicenseCheck.

      Here's the relevant config https://code.qt.io/cgit/qt/qt5.git/tree/coin/platform_configs/default.yaml?id=7ca4c85774e5ce9f87debb05b1e746e0934ab611#n92

      We should consider porting that behavior to use Coin yaml instructions.

      Here's a PoC implementation
      https://codereview.qt-project.org/c/tqtc-boot2qt/qtsaferenderer/+/267221/41/coin/module_config.yaml#364

      Note though, that for the instructions to be reusable between qt5 repos, the branch and repo name should not be hardcoded in the instructions, but should be computed dynamically somehow.

      So at least https://bugreports.qt.io/projects/COIN/issues/COIN-573?filter=allissues needs to be implemented.

      As a side note, porting to yaml is not a strict requirement even with the removal fo the qmake configs, because we don't need any binary artifacts.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            tosaario Toni Saario
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes