Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3935

Implement license checking for qt5.git repos (like qtbase) with new YAML instructions

    XMLWordPrintable

Details

    Description

      Currently all license checking is implemented via a legacy Coin feature called LicenseCheck.

      Here's the relevant config https://code.qt.io/cgit/qt/qt5.git/tree/coin/platform_configs/default.yaml?id=7ca4c85774e5ce9f87debb05b1e746e0934ab611#n92

      We should consider porting that behavior to use Coin yaml instructions.

      Here's a PoC implementation
      https://codereview.qt-project.org/c/tqtc-boot2qt/qtsaferenderer/+/267221/41/coin/module_config.yaml#364

      Note though, that for the instructions to be reusable between qt5 repos, the branch and repo name should not be hardcoded in the instructions, but should be computed dynamically somehow.

      So at least https://bugreports.qt.io/projects/COIN/issues/COIN-573?filter=allissues needs to be implemented.

      As a side note, porting to yaml is not a strict requirement even with the removal fo the qmake configs, because we don't need any binary artifacts.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTQAINFRA-3878 qtqa doesn't follow branch of modules it's integrating

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Open

          Task - A task that needs to be done. QTQAINFRA-4975 Figure out inconsistency of dev and master branches in qtqa repo

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported

          Task - A task that needs to be done. COIN-573 Coin should allow "current branch" variable in module_config.yaml

          • Not Evaluated - Not yet evaluated/prioritized
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-84233 Port qtqa to CMake

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTQAINFRA-3935
          # Subject Branch Project Status CR V
          329319,6 Add license check instructions dev qt/qtbase Status: NEW 0 0
          329320,2 Remove use legacy instructions flag from license check dev qt/qt5 Status: NEW 0 0
          329321,1 Add license check instructions dev qt/qtsvg Status: NEW 0 0
          329401,2 Add license check instructions dev qt/qtdeclarative Status: NEW 0 0
          329403,2 Add license check instructions dev qt/qtquick3d Status: NEW 0 0
          329404,2 Add license check instructions dev qt/qtdoc Status: NEW 0 0
          329405,2 Add license check instructions dev qt/qtquickcontrols2 Status: NEW 0 0
          329406,2 Add license check instructions dev qt/qtquicktimeline Status: NEW 0 0
          329407,2 Add license check instructions dev qt/qtshadertools Status: NEW 0 0
          329408,2 Add license check instructions dev qt/qttools Status: NEW 0 0
          329409,2 Add license check instructions dev qt/qtwayland Status: NEW 0 0
          329410,2 Add license check instructions dev qt/qttranslations Status: NEW 0 0
          329412,2 Add license check instructions dev qt/qt5compat Status: NEW 0 0
          329413,2 Add license check instructions dev qt/qtqa Status: NEW 0 0
          329414,4 Add dummy license check instructions dev qt/qt5 Status: NEW 0 0

          Activity

            People

              tosaario Toni Saario
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews