Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7033

Sanity bot gives -1 because of unrecognised git commit footers

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • unversioned
    • Sanity Bot
    • None

    Description

      https://codereview.qt-project.org/c/qt/qtbase/+/630559

      Qt Sanity Bot: Missing empty line between text and footers

      Commit message:

      Mark QByteArray and QString as security-critical
      
      These classes are usually the first line of defense, containing
      tainted data before anything else had the chance the verify it.
      
      Amends 8df072fc8006510c9b743e8ffedaaf51a876883a.
      
      QUIP: 23
      Pick-to: 6.9 6.9.0 6.8
      Change-Id: I91413e022b9794e21b6816b80962f5169ce8cd78
      

      I think the issue is that it doesn't recognise the QUIP footer.
      But it shouldn't matter. Footers should be accepted either they are known or unknown.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            jimis Dimitrios Apostolou
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes