Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7033

Sanity bot gives -1 because of unrecognised git commit footer "QUIP"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • None
    • unversioned
    • Sanity Bot
    • None
    • a83819f9c (master), c4da0dbfd (master)
    • Foundation Sprint 129

    Description

      https://codereview.qt-project.org/c/qt/qtbase/+/630559

      Qt Sanity Bot: Missing empty line between text and footers

      Commit message:

      Mark QByteArray and QString as security-critical
      
      These classes are usually the first line of defense, containing
      tainted data before anything else had the chance the verify it.
      
      Amends 8df072fc8006510c9b743e8ffedaaf51a876883a.
      
      QUIP: 23
      Pick-to: 6.9 6.9.0 6.8
      Change-Id: I91413e022b9794e21b6816b80962f5169ce8cd78
      

      I think the issue is that it doesn't recognise the QUIP footer.
      But it shouldn't matter. Footers should be accepted either they are known or unknown.

      Attachments

        For Gerrit Dashboard: QTQAINFRA-7033
        # Subject Branch Project Status CR V

        Activity

          People

            mmutz Marc Mutz
            jimis Dimitrios Apostolou
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes