-
Bug
-
Resolution: Unresolved
-
P3: Somewhat important
-
None
-
dev
-
None
In the olden days, the CI wouldn't upload the merged version of a change to Gerrit, but only post a comment. Therefore, if a commit message these days mentions such a sha-1 in "Amends", clicking on the link works in, say, gitk, but not in Gerrit.
This occasionally throws off reviewers, even though it's easily fixed by manually trying to remove the `commit:` particle from links when clicking such a link on Gerrit.
Example: https://codereview.qt-project.org/c/qt/qtbase/+/684655's Amends line.
Gerrit-produced link: https://codereview.qt-project.org/q/commit:2e0a4b13addf1f56112bac38448be96fb02f650d (comes up empty)
Manually edited link: https://codereview.qt-project.org/q/2e0a4b13addf1f56112bac38448be96fb02f650d (find the change, but also https://codereview.qt-project.org/c/qt/qtbase/+/684655)
If we want to fix this, there are two ways:
- change Gerrit link creation to omit the commit: particle. As history grows and Amends lines in commit messages become more frequent, this may end up showing too many commits
- upload missing merged changes to Gerrit: this would fix it with a one-off effort
I'd prefer the second approach, but don't know whether it's feasible.