Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7495

SHA-1 highlighting doesn't find older commits, need to remove `commit:` from the link

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3: Somewhat important P3: Somewhat important
    • None
    • dev
    • Gerrit
    • None

      In the olden days, the CI wouldn't upload the merged version of a change to Gerrit, but only post a comment. Therefore, if a commit message these days mentions such a sha-1 in "Amends", clicking on the link works in, say, gitk, but not in Gerrit.

      This occasionally throws off reviewers, even though it's easily fixed by manually trying to remove the `commit:` particle from links when clicking such a link on Gerrit.

      Example: https://codereview.qt-project.org/c/qt/qtbase/+/684655's Amends line.

      Gerrit-produced link: https://codereview.qt-project.org/q/commit:2e0a4b13addf1f56112bac38448be96fb02f650d (comes up empty)
      Manually edited link: https://codereview.qt-project.org/q/2e0a4b13addf1f56112bac38448be96fb02f650d (find the change, but also https://codereview.qt-project.org/c/qt/qtbase/+/684655)

      If we want to fix this, there are two ways:

      • change Gerrit link creation to omit the commit: particle. As history grows and Amends lines in commit messages become more frequent, this may end up showing too many commits
      • upload missing merged changes to Gerrit: this would fix it with a one-off effort

      I'd prefer the second approach, but don't know whether it's feasible.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            gerrit-admin Gerrit Admin
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes