Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104972

qUncompress(qCompress()) round-trip fails for data > 2GiB

XMLWordPrintable

    • 3
    • 2fd990b386 (qt/qtbase/dev) 2fd990b386 (qt/tqtc-qtbase/dev) 93aa02e671 (qt/qtbase/6.4) 93aa02e671 (qt/tqtc-qtbase/6.4) 2a4d5b41cb (qt/tqtc-qtbase/6.2) 93aa02e671 (qt/tqtc-qtbase/6.4.1) 93aa02e671 (qt/tqtc-qtbase/tqtc/qtinsight-6.4)
    • Foundation Sprint 61, Foundation Sprint 62, Foundation Sprint 63, Foundation Sprint 64, Foundation Sprint 65, Foundation Sprint 66, Foundation Sprint 67, Foundation Sprint 68

      The code fails on 64-bit platforms:

      const QByteArray ba = ~~~ more than 4GiB of data ~~~;
const QByteArray compressed = qCompress(ba);
const QByteArray uncompressed = qUncompress(compressed);
Q_COMPARE(ba, uncompressed);

      It seems to be caused by qCompress() using only four digits to encode the length.

      There doesn't appear to be something you can do, unless you change the format to include a longer length indicator.

        For Gerrit Dashboard: QTBUG-104972
        # Subject Branch Project Status CR V
        431005,8 Fix qUncompress for BE LLP64 platforms dev qt/qtbase Status: MERGED +2 0
        431007,2 [docs] qCompress/qUncompress: document size limits dev qt/qtbase Status: MERGED +2 0
        431109,4 qCompress: warn and reject input > ULONG_MAX dev qt/qtbase Status: ABANDONED -1 0
        431127,2 [docs] qCompress/qUncompress: document size limits 6.4 qt/qtbase Status: MERGED +2 0
        431128,2 [docs] qCompress/qUncompress: document size limits 6.3 qt/qtbase Status: MERGED +2 0
        431132,2 [docs] qCompress/qUncompress: document size limits tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        431186,6 qCompress: deal with potential overflows dev qt/qtbase Status: ABANDONED +2 0
        431187,3 tst_qbytearray: add test for qCompress/qUncompress cycle w/4GiB of data dev qt/qtbase Status: ABANDONED -1 0
        431265,2 qUncompress: mark invalidCompressedData() Q_DECL_COLD_FUNCTION dev qt/qtbase Status: MERGED +2 0
        431268,3 qUncompress: use existing MaxByteArraySize dev qt/qtbase Status: MERGED +2 0
        431366,2 qUncompress: mark invalidCompressedData() Q_DECL_COLD_FUNCTION 6.4 qt/qtbase Status: MERGED +2 0
        431367,1 qUncompress: mark invalidCompressedData() Q_DECL_COLD_FUNCTION 6.3 qt/qtbase Status: ABANDONED 0 0
        431414,4 qUncompress: mark invalidCompressedData() Q_DECL_COLD_FUNCTION tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        431562,5 qUncompress: limit MaxDecompressedSize to what zlib can handle dev qt/qtbase Status: MERGED +2 0
        431563,4 qUncompress: make a narrowing conversion explicit dev qt/qtbase Status: MERGED +2 0
        431564,2 Specialize qMulOverflow<2>(n) as qAddOverflow(n, n) dev qt/qtbase Status: MERGED +2 0
        431607,3 qUncompress: use existing MaxByteArraySize 6.4 qt/qtbase Status: MERGED +2 0
        431608,1 qUncompress: use existing MaxByteArraySize 6.3 qt/qtbase Status: ABANDONED 0 0
        431609,4 qUncompress: use existing MaxByteArraySize tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        431747,2 qCompress: use qToBigEndian() to write the length prefix dev qt/qtbase Status: MERGED +2 0
        431755,2 qCompress: simplify handling of Z_BUF_ERROR dev qt/qtbase Status: ABANDONED +2 0
        431907,3 qUncompress: limit MaxDecompressedSize to what zlib can handle 6.4 qt/qtbase Status: MERGED +2 0
        431908,1 qUncompress: limit MaxDecompressedSize to what zlib can handle 6.3 qt/qtbase Status: ABANDONED 0 0
        431911,3 qUncompress: limit MaxDecompressedSize to what zlib can handle tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        431913,3 Fix qUncompress for BE LLP64 platforms 6.4 qt/qtbase Status: MERGED +2 0
        431914,1 Fix qUncompress for BE LLP64 platforms 6.3 qt/qtbase Status: ABANDONED 0 0
        431915,3 qCompress: use qToBigEndian() to write the length prefix 6.4 qt/qtbase Status: MERGED +2 0
        431916,1 qCompress: use qToBigEndian() to write the length prefix 6.3 qt/qtbase Status: ABANDONED +2 0
        431917,4 Fix qUncompress for BE LLP64 platforms tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        431918,4 qCompress: use qToBigEndian() to write the length prefix tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        432081,2 Specialize qMulOverflow<2>(n) as qAddOverflow(n, n) 6.4 qt/qtbase Status: MERGED +2 0
        432185,1 qUncompress: make a narrowing conversion explicit 6.3 qt/qtbase Status: ABANDONED 0 0
        432186,2 qUncompress: make a narrowing conversion explicit 6.4 qt/qtbase Status: MERGED +2 0
        432189,4 qUncompress: make a narrowing conversion explicit tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        433375,7 qUncompress(): introduce more functions a la invalidCompressedData() dev qt/qtbase Status: MERGED +2 0
        433377,13 Port qUncompress() to zstream/inflate() dev qt/qtbase Status: MERGED +2 0
        433807,6 qUn/Compress: reject negative lengths dev qt/qtbase Status: MERGED +2 0
        433808,6 qCompress: use saturation, not truncation, for the size header dev qt/qtbase Status: MERGED +2 0
        433809,7 Port qCompress() to zstream/deflate() dev qt/qtbase Status: MERGED +2 0
        433810,3 tst_qbytearray: check compressing more than 4GiB of data dev qt/qtbase Status: ABANDONED -1 0
        434228,7 qCompress: return null, not empty, for OOM dev qt/qtbase Status: MERGED +2 0
        434637,1 qUncompress(): introduce more functions a la invalidCompressedData() 6.3 qt/qtbase Status: ABANDONED 0 0
        434718,3 qUncompress(): introduce more functions a la invalidCompressedData() 6.4 qt/qtbase Status: MERGED +2 0
        434720,3 qUn/Compress: reject negative lengths 6.4 qt/qtbase Status: MERGED +2 0
        434721,1 qUn/Compress: reject negative lengths 6.3 qt/qtbase Status: ABANDONED +2 0
        434724,4 qUncompress(): introduce more functions a la invalidCompressedData() tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        434726,4 qUn/Compress: reject negative lengths tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        435031,1 qCompress: return null, not empty, for OOM 6.3 qt/qtbase Status: ABANDONED +2 0
        435032,3 qCompress: return null, not empty, for OOM 6.4 qt/qtbase Status: MERGED +2 0
        435033,4 qCompress: use saturation, not truncation, for the size header 6.4 qt/qtbase Status: MERGED +2 0
        435034,1 qCompress: use saturation, not truncation, for the size header 6.3 qt/qtbase Status: ABANDONED 0 0
        435035,4 qCompress: return null, not empty, for OOM tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        435036,5 qCompress: use saturation, not truncation, for the size header tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        435911,2 Revert "qCompress: use saturation, not truncation, for the size header" dev qt/qtbase Status: ABANDONED 0 0
        435981,3 qnumeric_p.h: fix comparison of signed to unsigned in saturation dev qt/qtbase Status: MERGED +2 0
        436013,1 qnumeric_p.h: fix comparison of signed to unsigned in saturation 6.3 qt/qtbase Status: ABANDONED 0 0
        436014,3 qnumeric_p.h: fix comparison of signed to unsigned in saturation 6.4 qt/qtbase Status: MERGED +2 0
        436016,4 qnumeric_p.h: fix comparison of signed to unsigned in saturation tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        438416,3 Port qUncompress() to zstream/inflate() 6.4 qt/qtbase Status: MERGED +2 0
        438417,1 Port qUncompress() to zstream/inflate() 6.3 qt/qtbase Status: ABANDONED 0 0
        438498,4 Port qUncompress() to zstream/inflate() tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
        438733,1 Port qCompress() to zstream/deflate() 6.3 qt/qtbase Status: ABANDONED 0 0
        438734,3 Port qCompress() to zstream/deflate() 6.4 qt/qtbase Status: MERGED +2 0
        438737,4 Port qCompress() to zstream/deflate() tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0

            mmutz Marc Mutz
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes