Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138630

QLocale::toUpper() is not 64-bit-safe on Windows

    XMLWordPrintable

Details

    Description

      The code simply assumes that it can stuff QString::size() into an int parameter of LCMapString. In reality, this silently truncates, and may process only the first size() mod (INT_MAX+1) code points, failing the function's post-condition.

      git-blame fingers https://codereview.qt-project.org/c/qt/qtbase/+/476728 CC ulherman

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-138629 qlocale_win's toUpper/Lower is using LCMapString when the docs recommend LCMapStringEx

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-138583 QLocale::toUpper() is not 64-bit-safe on ICU

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • In Review
          resulted from

          Task - A task that needs to be done. QTBUG-135195 Review qtbase/src/corelib/text

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • In Progress
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Eddy Edward Welbourne
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes