Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
Description
The QEvent code contains the following Qt 5 to-do comments:
qevent.h
// ### Qt5: make internal class Q_GUI_EXPORT QUpdateLaterEvent : public QEvent
As source-incompatibile changes are no longer permitted for Qt 5, this comment must either be removed or changed to a Qt 6 to-do.
qevent_p.h
// ### Qt 5: remove class QKeyEventEx : public QKeyEvent
As this is in a private header, source-conpatibility is not an issue, so the comment can be actioned (or removed, or changed to a Qt 6 to-do).
qevent.cpp
QDropEvent::QDropEvent(const QPointF& pos, Qt::DropActions actions, const QMimeData *data, Qt::MouseButtons buttons, Qt::KeyboardModifiers modifiers, Type type) : QEvent(type), p(pos), mouseState(buttons), modState(modifiers), act(actions), mdata(data) { default_action = Qt::CopyAction; // ### Qt5: QDragManager::self()->defaultAction(act, modifiers); drop_action = default_action; ignore(); }
This comment does not appear to impact source or binary-compatibility so it probably does not have to be actioned for a major release (in which the comment should no longer say "Qt5".
Attachments
Issue Links
- resulted from
-
QTBUG-23524 [API] Grep the source for Qt5 todo items
- Closed
- resulted in
-
QTBUG-25373 Decide what to do with QDropEvent's ### Qt5 remark
- Closed
For Gerrit Dashboard: QTBUG-25070 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
22515,1 | Leave a more visible warning that the QPA port needs action | master | qt/qtbase | Status: ABANDONED | 0 | 0 |
22516,2 | Add a non-implicit copy constructor to QEvent | api_changes | qt/qtbase | Status: ABANDONED | +2 | 0 |
22517,1 | Get rid of QKeyEventEx | api_changes | qt/qtbase | Status: MERGED | +2 | 0 |
24994,3 | Add a non-implicit copy constructor to QEvent | master | qt/qtbase | Status: MERGED | +2 | 0 |
27317,1 | Remove QUpdateEvent from the public headers | master | qt/qtbase | Status: MERGED | +2 | 0 |