Loading...

XML

Word

Printable

Type: Task
Resolution: Done
Priority: P2: Important
Fix Version/s: 5.0.0 Beta 1
Affects Version/s: None
Component/s: Core: Event loop
Labels:
None

The QEvent code contains the following Qt 5 to-do comments:

qevent.h

// ### Qt5: make internal
class Q_GUI_EXPORT QUpdateLaterEvent : public QEvent

As source-incompatibile changes are no longer permitted for Qt 5, this comment must either be removed or changed to a Qt 6 to-do.

qevent_p.h

// ### Qt 5: remove
class QKeyEventEx : public QKeyEvent

As this is in a private header, source-conpatibility is not an issue, so the comment can be actioned (or removed, or changed to a Qt 6 to-do).

qevent.cpp

QDropEvent::QDropEvent(const QPointF& pos, Qt::DropActions actions, const QMimeData *data,
                       Qt::MouseButtons buttons, Qt::KeyboardModifiers modifiers, Type type)
    : QEvent(type), p(pos), mouseState(buttons),
      modState(modifiers), act(actions),
      mdata(data)
{
    default_action = Qt::CopyAction; // ### Qt5: QDragManager::self()->defaultAction(act, modifiers);
    drop_action = default_action;
    ignore();
}

This comment does not appear to impact source or binary-compatibility so it probably does not have to be actioned for a major release (in which the comment should no longer say "Qt5".

resulted from

QTBUG-23524 [API] Grep the source for Qt5 todo items