Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-83929

Scan through and port all defines, compile and link flags from mkspecs/foo/bar.conf files to relevant Qt::Platform or Qt::PlatformCommonInternal targets

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • None
    • 6.0.0
    • Build System: CMake

    Description

      For example 

      mkspecs/common/g++-win32.conf #  (MinGW)

      contains various 

      DEFINES, QMAKE_COMPILER_DEFINES, QMAKE_LFLAGS_EXCEPTIONS_ON

      etc flags which might not be ported to CMake, which leads to different compilation flags when building with CMake.

      I think the easiest would be to pick some .cpp file in Gui like image\qpixmapcache.cpp, and compare the compile and linker flags between a qmake and equivalent CMake platform configuration

      Add the appropriate missing definition flags to QT_DEFAULT_PLATFORM_DEFINITIONS in QtBuild.cmake.
      Afaik these are public mkspec flags which are used also when compiling user code (customer code that uses Qt).
      Public mkspec compile and link flags can be set on the Platform target in cmake/QtBaseGlobalTargets.cmake.

      There might also be some missing flags that come from private qmake files like qt_module.prf, qt_common.prf, qt_plugin.prf, etc

      The equivalent CMake targets are PlatformCommonInternal / PlatformModuleInternal / PlatformPluginInternal / PlatformToolInternal in cmake/QtInternalTargets.cmake.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-85353 Figure out and consolidate location for setting internal warning flags

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-85992 Make optimization flags consistent for Release and RelWithDebInfo in relation to qmake

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-85757 Implement CMake equivalent for load(qt_app)

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-84886 Fix remaining failing tests and enable enforcing successful test runs in the CI

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Task - A task that needs to be done. QTBUG-84461 gc_sections needs to be propagated from Core to other modules / executables in CMake configs

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-86879 Cannot build Qt sources with Clang-10 on Ubuntu 18 when ASan is enabled

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-75579 Replace platformdefs.h with CMake compile tests and remove mkspec concept

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open
          For Gerrit Dashboard: QTBUG-83929
          # Subject Branch Project Status CR V
          298985,4 CMake: Add some missing MinGW defines dev qt/qtbase Status: MERGED +2 0
          302055,3 CMake: Use -fapplication-extension when building Qt libraries on macOS dev qt/qtbase Status: MERGED +2 0
          304226,3 CMake: Add missing QT_USE_QSTRINGBUILDER define for tools dev qt/qtbase Status: MERGED +2 0
          304255,2 CMake: Fix usage of gc_binaries feature dev qt/qtbase Status: MERGED +2 0
          304263,2 CMake: Propagate largefile flags to all internal consumers dev qt/qtbase Status: MERGED +2 0
          304264,2 CMake: Make GL_SILENCE_DEPRECATION a public define for all consumers dev qt/qtbase Status: MERGED +2 0

          Activity

            People

              alexandru.croitor Alexandru Croitor
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: