Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-86840

Fix setupShadowMapVariableNames

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 6.0.0
    • Fix Version/s: 6.0.0
    • Component/s: Quick: 3D
    • Labels:
      None
    • Technical Risk:
      Normal
    • Commits:
      23105babfba2851bf948de2a8ac486c755efcaf9 (qt/qtquick3d/dev)
    • Story Points:
      2
    • Sprint:
      Qt Quick 3D - 39 - 40

      Description

          struct ShadowVariableNames
          {
              QByteArray shadowMapStem;
              QByteArray shadowCubeStem;
              QByteArray shadowMatrixStem;
              QByteArray shadowCoordStem;
              QByteArray shadowControlStem;
          };
      
      static QSSGMaterialShaderGenerator::ShadowVariableNames setupShadowMapVariableNames(size_t lightIdx)
      

      This function is called for every shadow casting light for each material in the scene from setRhiMaterialProperties(). That's far from ideal, given that it allocates five bytearrays and constructs them with appends and even qsnprintf.

        Attachments

        For Gerrit Dashboard: QTBUG-86840
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            tvete Paul Olav Tvete
            Reporter:
            lagocs Laszlo Agocs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes