Details
P2: Important Description
struct ShadowVariableNames
{
QByteArray shadowMapStem;
QByteArray shadowCubeStem;
QByteArray shadowMatrixStem;
QByteArray shadowCoordStem;
QByteArray shadowControlStem;
};
static QSSGMaterialShaderGenerator::ShadowVariableNames setupShadowMapVariableNames(size_t lightIdx)
This function is called for every shadow casting light for each material in the scene from setRhiMaterialProperties(). That's far from ideal, given that it allocates five bytearrays and constructs them with appends and even qsnprintf.
Attachments
| For Gerrit Dashboard: QTBUG-86840 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 320075,3 | Make setupShadowMapVariableNames cheap | dev | qt/qtquick3d | Status: MERGED | +2 | 0 |