Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-86840

Fix setupShadowMapVariableNames

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: P2: Important P2: Important
    • 6.0.0
    • 6.0.0
    • Quick: 3D
    • None
    • 2
    • 23105babfba2851bf948de2a8ac486c755efcaf9 (qt/qtquick3d/dev)
    • Qt Quick 3D - 39 - 40

          struct ShadowVariableNames
          {
              QByteArray shadowMapStem;
              QByteArray shadowCubeStem;
              QByteArray shadowMatrixStem;
              QByteArray shadowCoordStem;
              QByteArray shadowControlStem;
          };
      
      static QSSGMaterialShaderGenerator::ShadowVariableNames setupShadowMapVariableNames(size_t lightIdx)
      

      This function is called for every shadow casting light for each material in the scene from setRhiMaterialProperties(). That's far from ideal, given that it allocates five bytearrays and constructs them with appends and even qsnprintf.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            tvete Paul Olav Tvete
            lagocs Laszlo Agocs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes