Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-94581 Review and Document new Qt 6.2 CMake API
  3. QTBUG-95169

Rename qt6_enable_import_plugins_finalizer_mode and qt6_enable_object_libraries_finalizer_mode

    XMLWordPrintable

Details

    • 5161d8d525650ac74a3571b13bb8b35dbf413e59 (qt/qtbase/dev) e8859b732dcefcdc46b66b5518e64feae29d35c4 (qt/qtbase/6.2)

    Description

      Context https://git.qt.io/alcroito/qt6-cmake-api-review/-/commit/5313c017d09c51d9034dd62b33f968b9cd54363c#179fb5213a114272e340c63285f9fb35ba530ab8_177_187

      We should rename / combine the 2 functions called qt6_enable_object_libraries_finalizer_mode and qt_enable_import_plugins_finalizer_mode into a single function that takes a list of 'contexts' where finalizer mode should be enabled / disabled.

      Before we do that, we should wait a bit until CMake 3.21.0 is released, because that means we can at least get rid of qt6_enable_object_libraries_finalizer_mode. In this case, we still want a more generic 'contexts' taking function.
      Note if 3.21.0 is released soon enough, this will depend on QTBUG-95018 being done first.

      Attachments

        Issue Links

          depends on

          Technical task - A technical task. QTBUG-95018 Change the minimum required CMake version for building and using Qt

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          relates to

          Technical task - A technical task. QTBUG-95603 Remove workarounds for linking object libraries in static Qt builds

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          resulted in

          Task - A task that needs to be done. QTBUG-95601 Remove unnecessary static linking tests based on requiring CMake 3.21

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          For Gerrit Dashboard: QTBUG-95169
          # Subject Branch Project Status CR V
          363442,12 CMake: Remove qt6_enable_object_libraries_finalizer_mode dev qt/qtbase Status: MERGED +2 0
          364061,3 CMake: Remove qt6_enable_object_libraries_finalizer_mode 6.2 qt/qtbase Status: MERGED +2 0

          Activity

            People

              alexandru.croitor Alexandru Croitor
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes