Details
-
Suggestion
-
Resolution: Unresolved
-
Not Evaluated
-
None
-
None
-
None
-
5e1a17873 (dev)
Description
It's never OK to use module-wide includes (e.g. #include <QtCore>), so Qt should never do that. This includes examples and autotests. The bot should flag any code that adds such an include.
The biggest offender is #include <QtTest> when one likelywanted to type #include <QTest>, accidentally including all of QtCore as a dependency.
When QtTest was purged out of qtbase, testcases build time was reduced by 25%, so that's absolutely significant. But I see that it got added (back?).
Attachments
Gerrit Reviews
For Gerrit Dashboard: QTQAINFRA-7110 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
638760,42 | Tests: include QTest, not QtTest | dev | qt/qtdeclarative | Status: NEW | 0 | 0 |