Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7110

Have the sanity bot complain when using module-wide includes

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • None
    • Sanity Bot
    • None
    • 5e1a17873 (dev), cb84d80c8 (6.9), 6bbc58793 (6.8)

    Description

      It's never OK to use module-wide includes (e.g. #include <QtCore>), so Qt should never do that. This includes examples and autotests. The bot should flag any code that adds such an include.

      The biggest offender is #include <QtTest> when one likelywanted to type #include <QTest>, accidentally including all of QtCore as a dependency.

      When QtTest was purged out of qtbase, testcases build time was reduced by 25%, so that's absolutely significant. But I see that it got added (back?).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            peppe Giuseppe D'Angelo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes