Details
-
Suggestion
-
Resolution: Unresolved
-
Not Evaluated
-
None
-
None
-
None
-
5e1a17873 (dev), cb84d80c8 (6.9), 6bbc58793 (6.8)
Description
It's never OK to use module-wide includes (e.g. #include <QtCore>), so Qt should never do that. This includes examples and autotests. The bot should flag any code that adds such an include.
The biggest offender is #include <QtTest> when one likelywanted to type #include <QTest>, accidentally including all of QtCore as a dependency.
When QtTest was purged out of qtbase, testcases build time was reduced by 25%, so that's absolutely significant. But I see that it got added (back?).
Attachments
Gerrit Reviews
| For Gerrit Dashboard: QTQAINFRA-7110 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 638760,43 | Tests: include QTest, not QtTest | dev | qt/qtdeclarative | Status: INTEGRATING | +2 | 0 |
| 638808,2 | Include <QTest>, not <QtTest> | dev | qt/qtbase | Status: MERGED | +2 | +1 |
| 638909,2 | Include <QTest>, not <QtTest> | 6.9 | qt/qtbase | Status: MERGED | +2 | 0 |
| 639745,2 | Include <QTest>, not <QtTest> | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |