Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104113

Modernize comparisons: can we provide macros?

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • P2: Important
    • 6.7.0 FF
    • None
    • Core: Other
    • None
    • 21
    • 5a28aacd8 (dev), fe12650e9 (dev), 96f494bf9 (dev), 4b755bc11 (dev), 43d3d0376 (dev), 9eb1eb10c (6.6), 3d231e27a (dev), 0aad68f97 (tqtc/lts-6.5)
    • Foundation Sprint 81, Foundation Sprint 82, Foundation Sprint 83, Foundation Sprint 84, Foundation Sprint 85, Foundation Sprint 86, Foundation Sprint 87, Foundation Sprint 88, Foundation Sprint 89, Foundation Sprint 90, Foundation Sprint 91, Foundation Sprint 92, Foundation Sprint 93, Foundations Sprint 94, Foundations Sprint 95, Foundations Sprint 96, Foundations Sprint 97

    Description

      See epic for more information.

      We're asking all maintainers to execute the following programme:

      For each pair of types that are comparable:

      • add private
        • equals() as a back-end for == and
        • compare() as a back-end for <=> that can be out-of-line (cf. QTBUG-100276)
      • a classification (incl. user docs! (QTBUG-104110)) into exactly one of
        • strong
        • partial
        • weak
      • add tests for all relational operators (QTBUG-104108)
      • all traditional relational operators (==, !=, <, >, <=, >=) that work in C++20 (incl. synthesized ones) should also work in C++17.

      Explore how much of this we can hide behind macros, and define such macros.

      Attachments

        Issue Links

          depends on

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-104110 Support easy, yet precise, documenting of relational operators

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-104108 As a user of QTestLib, I want to use QCOMPARE_op with C++20's spaceship operator <=>

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          is required for

          Task - A task that needs to be done. QTBUG-104111 Modernize comparisons [Core: Date/Time]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-113234 Modernize comparisons [Core: QVariant]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-117660 Modernize comparisons [Core: Item Views]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-117661 Modernize comparisons [Core: Strings]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120300 Modernize comparisons [Core: Serialization]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120303 Modernize comparisons [Core: I/O]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120304 Modernize comparisons [Core: <rest>]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120305 Modernize comparisons [Core: Containers (ex strings)]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120306 Modernize comparisons [Core: Smart Pointers]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120308 Modernize comparisons [Core: Geometric Classes]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120359 Modernize comparisons [Core: QTypeRevision]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-120360 Modernize comparisons [Core: QOperatingSystemVersion]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-118193 qfloat16 compares all integral values outside its range equal to infinity

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-117637 qfloat16 comparison with integral types is ambiguous

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted in

          Task - A task that needs to be done. QTBUG-119433 C++20 comparison 6.7 remaining tasks

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-104113
          # Subject Branch Project Status CR V
          490932,6 [normative] QUIP-0020: C++20 Comparison master meta/quips Status: NEW +1 0
          474834,2 Introduce QStrongOrdering and QWeakOrdering dev qt/qtbase Status: ABANDONED -2 0
          475447,63 Implement compare helper macros dev qt/qtbase Status: MERGED +2 0
          478199,54 Implement helper Qt::compareThreeWay() function for built-in types dev qt/qtbase Status: MERGED +2 0
          507045,11 Overcome MSVC bugs when detecting C++20 comparison dev qt/qtbase Status: ABANDONED +1 0
          507383,40 Teach Qt::compareThreeWay() to support native float16 types dev qt/qtbase Status: MERGED +2 0
          508464,37 Long live qCompareThreeWay() dev qt/qtbase Status: MERGED +2 0
          518702,15 Implement checking of op<=> in the compare test helpers dev qt/qtbase Status: MERGED +2 0
          523348,4 Move the definition of a native float from qfloat16.h to qtypes.h dev qt/qtbase Status: MERGED +2 0
          523513,2 Move the definition of a native float from qfloat16.h to qtypes.h 6.6 qt/qtbase Status: MERGED +2 0
          523665,3 Move the definition of a native float from qfloat16.h to qtypes.h tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0

          Activity

            People

              ivan.solovev Ivan Solovev
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: